[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 04 May 2007 20:38:43 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Michael Chan <mchan@...adcom.com>
CC: davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 8/11][TG3]: Add TG3_FLAG_SUPPORT_MSI flag.
Michael Chan wrote:
> @@ -10404,6 +10400,8 @@ static void __devinit tg3_read_fw_ver(struct tg3 *tp)
> }
> }
>
> +static struct pci_dev * __devinit tg3_find_peer(struct tg3 *);
> +
> static int __devinit tg3_get_invariants(struct tg3 *tp)
> {
> static struct pci_device_id write_reorder_chipsets[] = {
Prototypes are better kept at the top of the file, grouped together. It
can sometimes be a pain later on, if they are scattered throughout a big
source file like tg3.c.
ACK the patch's content of course
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists