netdev - Re: [PATCH] [TCP] FRTO: remove unnecessary fackets/sacked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070507.004724.115914377.davem@davemloft.net>
Date:	Mon, 07 May 2007 00:47:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [TCP] FRTO: remove unnecessary fackets/sacked_out
 recounting

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Mon, 7 May 2007 10:34:33 +0300 (EEST)

> On Sat, 21 Apr 2007, Ilpo Järvinen wrote:
> 
> > F-RTO does not touch SACKED_ACKED bits at all, so there is no
> > need to recount them in tcp_enter_frto_loss. After removal of
> > the else branch, the nested ifs can be combined.
> 
> Just in case you come across this, please do not apply it! I noticed that 
> even though it seems very innocent change, it will cause S+L when SACK is 
> not in use because sacked_out is not reset. I'll provide updated patch for 
> this later on...

Ok.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html