lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 May 2007 13:56:41 +0200 From: Krzysztof Halasa <khc@...waw.pl> To: Roman Zippel <zippel@...ux-m68k.org> Cc: Jeff Garzik <jeff@...zik.org>, Russell King <rmk@....linux.org.uk>, lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Roman Zippel <zippel@...ux-m68k.org> writes: >> You don't have to know it's required, you can just select a driver >> for your hardware, without enabling HDLC first. > > Is this a real problem? I think the "select" is better. > Using select you should also consider removing HDLC as visible option and > use only select. Mixing depends and selects is generally a bad idea. It has to stay there for external modules. It's similar to MII - drivers select MII automatically but you can turn it on (Y or M) by hand as well. And you can have HDLC=y and driver=m (and it makes perfect sense). Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists