netdev - Re: [PATCH v2] Add rtl8187 wireless driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463F44E6.5030705@garzik.org>
Date:	Mon, 07 May 2007 11:25:26 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Michael Wu <flamingice@...rmilk.net>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org,
	John Linville <linville@...driver.com>,
	Andrea Merello <andrea.merello@...il.com>
Subject: Re: [PATCH v2] Add rtl8187 wireless driver

Michael Wu wrote:
> This patch adds a mac80211 based wireless driver for the rtl8187 USB
> wireless card.
> 
> Signed-off-by: Michael Wu <flamingice@...rmilk.net>
> ---
> 
>  MAINTAINERS                                    |   10 
>  drivers/net/wireless/Kconfig                   |    2 
>  drivers/net/wireless/Makefile                  |    3 
>  drivers/net/wireless/rtl818x/Kconfig           |   16 +
>  drivers/net/wireless/rtl818x/Makefile          |    2 
>  drivers/net/wireless/rtl818x/rtl8187.h         |  125 ++++
>  drivers/net/wireless/rtl818x/rtl8187_dev.c     |  730 ++++++++++++++++++++++++
>  drivers/net/wireless/rtl818x/rtl8187_rtl8225.c |  744 ++++++++++++++++++++++++
>  drivers/net/wireless/rtl818x/rtl8187_rtl8225.h |   30 +
>  drivers/net/wireless/rtl818x/rtl818x.h         |  212 +++++++
>  10 files changed, 1874 insertions(+), 0 deletions(-)

Much better.

For the record, new wireless drivers go TO John Linville for merging 
(and he pushes to me, in turn).

I am a bit skeptical that multiple files are needed.  It seems like 
drivers/net/wireless/rtl818x.c would be a better path, a la tg3.c.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html