netdev - Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070506204041.db0ff08a.randy.dunlap@oracle.com>
Date:	Sun, 6 May 2007 20:40:41 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	bryan.wu@...log.com, netdev <netdev@...r.kernel.org>
Subject: Re: [patch 089/181] Blackfin: on-chip ethernet MAC controller
 driver

On Sun, 06 May 2007 20:20:40 -0400 Jeff Garzik wrote:

> akpm@...ux-foundation.org wrote:
> > From: "Wu, Bryan" <bryan.wu@...log.com>
> > 
> > This patch implements the driver necessary use the Analog Devices
> > Blackfin processor's on-chip ethernet MAC controller.
> > 
> > Signed-off-by: Bryan Wu <bryan.wu@...log.com>
> > Cc: Jeff Garzik <jeff@...zik.org>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > ---
> > 
> >  drivers/net/Kconfig    |   44 +
> >  drivers/net/Makefile   |    1 
> >  drivers/net/bfin_mac.c |  981 +++++++++++++++++++++++++++++++++++++++
> >  drivers/net/bfin_mac.h |  147 +++++
> >  4 files changed, 1173 insertions(+)
> 
> WTF?
> 
> Why are new network drivers not going to me, netdev, and/or DaveM?

because people are dumping Everything to lkml :(

> Something is really broken here.  What is it?

Use netdev, linux-scsi, linux-ide, linux-usb-devel, linux-ieee1394,
etc., instead of one-list-fits-all.


> I NAK this driver purely on the basis of lack of review.

Yep.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html