lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 May 2007 01:06:34 -0400 From: Jeff Garzik <jeff@...zik.org> To: Stephen Hemminger <shemminger@...ux-foundation.org> CC: netdev@...r.kernel.org, stable@...nel.org Subject: Re: [PATCH 1/2] skge: default WOL should be magic only Stephen Hemminger wrote: > By default, the skge driver now enables wake on magic and wake on PHY. > This is a bad default (bug), wake on PHY means machine will never shutdown > if connected to a switch. > > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>a > > --- > drivers/net/skge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- sky2-2.6.21.orig/drivers/net/skge.c 2007-05-07 10:01:47.000000000 -0700 > +++ sky2-2.6.21/drivers/net/skge.c 2007-05-07 10:03:29.000000000 -0700 > @@ -3591,7 +3591,7 @@ static struct net_device *skge_devinit(s > skge->duplex = -1; > skge->speed = -1; > skge->advertising = skge_supported_modes(hw); > - skge->wol = pci_wake_enabled(hw->pdev) ? wol_supported(hw) : 0; > + skge->wol = pci_wake_enabled(hw->pdev) ? WAKE_MAGIC : 0; NAK. You still need to check for buggy chips (as in patch #2) If stable@...nel.org applied this, they need to fix it as you will for upstream... Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists