netdev - Re: [PATCH] tc35815: Remove unnecessary skb->dev assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46400DB7.1080500@garzik.org>
Date:	Tue, 08 May 2007 01:42:15 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] tc35815: Remove unnecessary skb->dev assignment

Atsushi Nemoto wrote:
> Apply changes in commit 4c13eb6657fe9ef7b4dc8f1a405c902e9e5234e0 to
> newly added piece of code.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index f1e2dfc..463d600 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -540,7 +540,6 @@ static struct sk_buff *alloc_rxbuf_skb(struct net_device *dev,
>  	skb = dev_alloc_skb(RX_BUF_SIZE);
>  	if (!skb)
>  		return NULL;
> -	skb->dev = dev;
>  	*dma_handle = pci_map_single(hwdev, skb->data, RX_BUF_SIZE,
>  				     PCI_DMA_FROMDEVICE);

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html