netdev - Re: [PATCH v3] [8/10] pasemi_mac: Add msglevel support and "pasemi_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070508053327.GB14152@lixom.net>
Date:	Tue, 8 May 2007 00:33:27 -0500
From:	olof@...om.net (Olof Johansson)
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] [8/10] pasemi_mac: Add msglevel support and "pasemi_mac_debug" module param

On Tue, May 08, 2007 at 01:03:12AM -0400, Jeff Garzik wrote:
> Olof Johansson wrote:
> >+	/* Enable most messages by default */
> >+	if (pasemi_mac_debug > 0)
> >+		mac->msg_enable = DEFAULT_MSG_ENABLE;
> >+	else
> >+		mac->msg_enable = pasemi_mac_debug;
> >+
> 
> 
> use netif_msg_init()

Thanks. It's also needlessly verbose to have the module parameter that
long. Other drivers just use "debug", so I switched to the same.


-Olof
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html