netdev - Re: linkwatch bustage in git-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070509.143925.25157363.davem@davemloft.net>
Date:	Wed, 09 May 2007 14:39:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: linkwatch bustage in git-net

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Wed, 9 May 2007 14:11:03 -0700

> On Wed, 09 May 2007 00:18:14 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
> > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > 
> > Thanks for working this out, applied and pushed to net-2.6.git
> 
> I'm all confused.  I just pulled your tree and I see in the log
> 
> 
> 	commit 4cba637dbb9a13706494a1c85174c8e736914010
> 	Author: Herbert Xu <herbert@...dor.apana.org.au>
> 	Date:   Wed May 9 00:17:30 2007 -0700
> 
> 	    [NET] link_watch: Always schedule urgent events
>     
> 
> and
> 
> 
> 	commit fe47cdba83b3041e4ac1aa1418431020a4afe1e0
> 	Author: Herbert Xu <herbert@...dor.apana.org.au>
> 	Date:   Tue May 8 23:22:43 2007 -0700
> 
> 	    [NET] link_watch: Eliminate potential delay on wrap-around
> 
> 
> but in the actual diff and in the checked-out tree I see no sign of the
> earlier patch (fe47cdba83b3041e4ac1aa1418431020a4afe1e0).  I have the old
> code:
> 
>         /* If we wrap around we'll delay it by at most HZ. */
>         if (delay > HZ)
>                 delay = 0;
> 
> 
> where'd it go?

Look at the two individual changes, Herbert implemented the
delay calculations different in the second changeset.  So
the code is much different there now.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html