netdev - Re: [1/2] [NET] link_watch: Move link watch list into net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070508.183526.108739707.davem@davemloft.net>
Date:	Tue, 08 May 2007 18:35:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	jeremy@...p.org, hch@...radead.org, ak@...e.de,
	akpm@...ux-foundation.org, virtualization@...ts.osdl.org,
	linux-kernel@...r.kernel.org, chrisw@...s-sol.org,
	ian.pratt@...source.com, Christian.Limpach@...cam.ac.uk,
	netdev@...r.kernel.org, jeff@...zik.org,
	shemminge@...ux-foundation.org, rusty@...tcorp.com.au,
	Keir.Fraser@...cam.ac.uk
Subject: Re: [1/2] [NET] link_watch: Move link watch list into net_device

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 8 May 2007 22:13:22 +1000

> [NET] link_watch: Move link watch list into net_device
> 
> These days the link watch mechanism is an integral part of the
> network subsystem as it manages the carrier status.  So it now
> makes sense to allocate some memory for it in net_device rather
> than allocating it on demand.
> 
> In fact, this is necessary because we can't tolerate a memory
> allocation failure since that means we'd have to potentially
> throw a link up event away.
> 
> It also simplifies the code greatly.
> 
> In doing so I discovered a subtle race condition in the use
> of singleevent.  This race condition still exists (and is
> somewhat magnified) without singleevent but it's now plugged
> thanks to an smp_mb__before_clear_bit.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html