netdev - Re: [NET_SCHED]: Avoid requeue warning on dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070510.141310.09953417.davem@davemloft.net>
Date:	Thu, 10 May 2007 14:13:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [NET_SCHED]: Avoid requeue warning on dev_deactivate

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 10 May 2007 22:53:04 +1000

> [NET_SCHED]: Avoid requeue warning on dev_deactivate
> 
> When we relinquish queue_lock in qdisc_restart and then retake it for
> requeueing, we might race against dev_deactivate and end up requeueing
> onto noop_qdisc.  This causes a warning to be printed.
> 
> This patch fixes this by checking this before we requeue.  As an added
> bonus, we can remove the same check in __qdisc_run which was added to
> prevent dev->gso_skb from being requeued when we're shutting down.
> 
> Even though we've had to add a new conditional in its place, it's better
> because it only happens on requeues rather than every single time that
> qdisc_run is called.
> 
> For this to work we also need to move the clearing of gso_skb up in
> dev_deactivate as now qdisc_restart can occur even after we wait for
> __LINK_STATE_QDISC_RUNNING to clear (but it won't do anything as long
> as the queue and gso_skb is already clear).
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>


Looks good, applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html