[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0705100015270.27791@localhost.localdomain>
Date: Thu, 10 May 2007 00:15:43 -0500 (CDT)
From: Kumar Gala <galak@...nel.crashing.org>
To: Timur Tabi <timur@...escale.com>
cc: linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4] powerpc: change rheap functions to use ulongs instead
of pointers
On Tue, 8 May 2007, Timur Tabi wrote:
> The rheap allocation functions return a pointer, but the actual value is based
> on how the heap was initialized, and so it can be anything, e.g. an offset
> into a buffer. A ulong is a better representation of the value returned by
> the allocation functions.
>
> This patch changes all of the relevant rheap functions to use a unsigned long
> integers instead of a pointer. In case of an error, the value returned is
> a negative error code that has been cast to an unsigned long. The caller can
> use the IS_ERR_VALUE() macro to check for this.
>
> All code which calls the rheap functions is updated accordingly. Macros
> IS_MURAM_ERR() and IS_DPERR(), have been deleted in favor of IS_ERR_VALUE().
>
> Also added error checking to rh_attach_region().
>
> Signed-off-by: Timur Tabi <timur@...escale.com>
applied.
- k
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists