netdev - Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <049301c792c8$ecdf4c40$0202fea9@Jura>
Date:	Thu, 10 May 2007 10:03:23 +0400
From:	"Yuriy N. Shkandybin" <jura@...ams.com>
To:	"Jarek Poplawski" <jarkao2@...pl>
Cc:	<akpm@...ux-foundation.org>, <netdev@...r.kernel.org>,
	<paulus@...ba.org>, <greearb@...delatech.com>,
	<mostrows@...akeasy.net>, <davem@...emloft.net>
Subject: Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: ppp_generic: fix lockdep warning

Yes, there is no real lockup with pppoe
ll repeat my configuration:
vpn (pptp(mostly)+pppoe) concentrator
PPPoE provided through 802.1q
+OSPF (quagga)

Jura

----- Original Message ----- 
From: "Jarek Poplawski" <jarkao2@...pl>
To: "Yuriy N. Shkandybin" <jura@...ams.com>
Cc: <akpm@...ux-foundation.org>; <netdev@...r.kernel.org>; 
<paulus@...ba.org>; <greearb@...delatech.com>; <mostrows@...akeasy.net>; 
<davem@...emloft.net>
Sent: Thursday, May 10, 2007 9:30 AM
Subject: Re: [PATCH] vlan: lockdep subclass for ppp _xmit_lock Re: 
ppp_generic: fix lockdep warning


> On Thu, May 10, 2007 at 12:06:09AM +0400, Yuriy N. Shkandybin wrote:
>> After applying this patch i've got this:
>>
>> =======================================================
>> [ INFO: possible circular locking dependency detected ]
>> 2.6.21-gentoo #2
>> -------------------------------------------------------
>> ospfd/3984 is trying to acquire lock:
>> (&ppp->wlock){-...}, at: [<ffffffff803512a0>] ppp_xmit_process+0x20/0x4f0
>>
>> but task is already holding lock:
>> (&dev->_xmit_lock){-+..}, at: [<ffffffff8038d778>] __qdisc_run+0x88/0x1c3
>>
>> which lock already depends on the new lock.
>
> Thanks Yuriy!
>
> As a matter of fact I suspected there will be something more.
> Lockdep always stops working after the first warning, and you
> have some very interesting (entangled) configuration, so each
> fix could uncover new warnings.
>
> I need some time to figure out this one, so I'd try to use your
> help yet... I hope it's only about lockdep warnings and there
> are no real lockups.
>
> Best regards,
> Jarek P.
> 

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html