netdev - Re: [NET]: Fix dev->qdisc race for NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1Hm7Er-0006Wk-00@gondolin.me.apana.org.au>
Date:	Thu, 10 May 2007 21:55:17 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	tgraf@...g.ch (Thomas Graf)
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [NET]: Fix dev->qdisc race for NETDEV_TX_LOCKED case

Thomas Graf <tgraf@...g.ch> wrote:
> When transmit fails with NETDEV_TX_LOCKED the skb is requeued
> to dev->qdisc again. The dev->qdisc pointer is protected by
> the queue lock which needs to be dropped when attempting to
> transmit and acquired again before requeing. The problem is
> that qdisc_restart() fetches the dev->qdisc pointer once and
> stores it in the `q' variable which is invalidated when
> dropping the queue_lock, therefore the variable needs to be
> refreshed before requeueing.
> 
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

I agree, good catch Thomas.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html