netdev - Re: [PATCH] sched: Optimize return value of qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178803084.4074.48.camel@localhost>
Date:	Thu, 10 May 2007 09:18:04 -0400
From:	jamal <hadi@...erus.ca>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, krkumar2@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart

On Thu, 2007-10-05 at 22:59 +1000, Herbert Xu wrote:
> jamal <hadi@...erus.ca> wrote:

> 			This release qlock isn't in our source code :)

This is why i defered this to you ;-> 
For completion sake, this is how it looks like:
 
 CPU0                 CPU1
  | wait qlock         |
  |                    |
  |                    + find that return code is 0
  |                    + release qdisc running
  |                    + release qlock
  + grab qlock         + ==> outta here
  | enq pktx           |
  | call qdisc_run     |
  +  grab running
  |  deq etc
  +  release running
  + release qlock
  + ==> outta here    

I wonder how much performance improvement this give now that the extra
incursion into qdisc_restart is avoided.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html