netdev - Re: [PATCH 05/17] pci: advanced error reporting stub return values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070510084825.2a8d3add@freepuppy>
Date:	Thu, 10 May 2007 08:48:25 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Greg KH <greg@...ah.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	Tom Long Nguyen <tom.l.nguyen@...el.com>,
	Zhang Yanmin <yanmin.zhang@...el.com>,
	linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH 05/17] pci: advanced error reporting stub return values

On Tue, 08 May 2007 20:49:54 -0700
Stephen Hemminger <shemminger@...ux-foundation.org> wrote:

> The stubs for advanced PCI error reporting are wrong. They don't
> match the function return values. This breaks compilation for any
> driver that tries to use these functions (that's the next sky2 patch).
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> 
> --- sky2.orig/include/linux/aer.h	2007-05-08 20:36:21.000000000 -0700
> +++ sky2/include/linux/aer.h	2007-05-08 20:38:04.000000000 -0700
> @@ -14,10 +14,10 @@
>  extern int pci_disable_pcie_error_reporting(struct pci_dev *dev);
>  extern int pci_cleanup_aer_uncorrect_error_status(struct pci_dev *dev);
>  #else
> -#define pci_enable_pcie_error_reporting(dev)		do { } while (0)
> -#define pci_find_aer_capability(dev)			do { } while (0)
> -#define pci_disable_pcie_error_reporting(dev)		do { } while (0)
> -#define pci_cleanup_aer_uncorrect_error_status(dev)	do { } while (0)
> +#define pci_enable_pcie_error_reporting(dev)		(-EINVAL)
> +#define pci_find_aer_capability(dev)			(0)
> +#define pci_disable_pcie_error_reporting(dev)		(-EINVAL)
> +#define pci_cleanup_aer_uncorrect_error_status(dev)	(-EINVAL)
>  #endif
>  
>  #endif //_AER_H_
> 
> --

Greg could you put this in as a bug fix now.
I don't think I'll put in the usage of aer funcs until 2.6.22 -mm, but
hopefully this will be fixed by then.


-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html