netdev - Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070510090010.4c6b8589@freepuppy>
Date:	Thu, 10 May 2007 09:00:10 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Daniel Drake <dsd@...too.org>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	stable@...nel.org, Francois SIMOND <curio@...e.fr>
Subject: Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

On Tue, 01 May 2007 09:58:28 -0400
Daniel Drake <dsd@...too.org> wrote:

> Hi Stephen,
> 
> Stephen Hemminger wrote:
> > This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
> > Allow all but the Gigabyte motherboard has some unresolved bus problems.
> 
> > +	/* Some Gigabyte motherboards have 88e8056 but cause problems
> > +	 * There is some unresolved hardware related problem that causes
> > +	 * descriptor errors and receive data corruption.
> > +	 */
> > +	if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
> > +	    pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
> > +		dev_err(&pdev->dev,
> > +			"88E8056 on Gigabyte motherboards not supported\n");
> 
> Gentoo have reports of sky2 working fine on Gigabyte boards which have 
> 88E8056 devices:
> https://bugs.gentoo.org/show_bug.cgi?id=176219
> 
> Can the patch be refined further?

I can use DMI to narrow down to one motherboard. 
Or just let everything through and let user's discover what's unstable, it fails
relatively quickly.

Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U)
systems? It might be some PCI Express setup by the BIOS, but so far haven't
found any difference that mattered.

Have tried newer BIOS and qualified memory as obvious first steps.


-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html