netdev - [PATCH 2.6.20] Corrects small word-size dependency in exposed kernel structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <46443EDF.1080108@abovesecurity.com>
Date:	Fri, 11 May 2007 06:01:03 -0400
From:	"Marc A. Pelletier" <marc@...vesecurity.com>
To:	netdev@...r.kernel.org
Subject: [PATCH 2.6.20] Corrects small word-size dependency in exposed kernel
 structure

Corrects a small word-size dependency in an exposed kernel structure
so that mmaped packet sockets will work correctly from 32-bit userspace
on a 64-bit kernel.

Signed-off-by: Marc A. Pelletier <marc@...vesecurity.com>
---

As an aside, I've considered changing the setsockopt() for that feature
so that it returns critical values back to userspace (stride between
frames, actual offsets of substructures) rather than needing userspace
to guess them, but that can't be done without

(a) breaking current users of PACKET_RX_RING; or
(b) adding a new setsockopt.

Which is best?

Also, I have a couple of sanity fixes for the ring packet implementation
I'd like to discuss.  Anyone specific maintaining that bit of code?

-- Marc A. Pelletier

--- orig/include/linux/if_packet.h      2007-05-10 14:27:49 -0400
+++ new/include/linux/if_packet.h   2007-05-10 14:27:50 -0400
@@ -50,7 +50,7 @@

 struct tpacket_hdr
 {
-       unsigned long   tp_status;
+       unsigned int    tp_status;
 #define TP_STATUS_KERNEL       0
 #define TP_STATUS_USER         1
 #define TP_STATUS_COPY         2

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html