netdev - RE: [RFC] make qdisc_restart more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32902D42246@orsmsx414.amr.corp.intel.com>
Date:	Fri, 11 May 2007 08:56:04 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<hadi@...erus.ca>, "Herbert Xu" <herbert@...dor.apana.org.au>,
	"David Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [RFC] make qdisc_restart more readable

> This compiles and passes some basic tests - no serious testing.
> Against net-2.6.
> 
> The patch is ugly looking, so i have at the end the 
> re-written qdisc; you can easily tell the rest from the patch.
> 
> Please flush out any fluff - I would like to submit this 
> (almost lost it, thanks to an early posting, found it).
> 
> 
> cheers,
> jamal

In qdisc_restart(), you removed any check for if
(!netif_queue_stopped(dev)) before calling dev_hard_start_xmit().  If
the underlying queue is stopped and you send the skb, you'll generate a
requeue.  Is there a reason it was removed?

Thx,

-PJ Waskiewicz 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html