netdev - RE: [RFC] make qdisc_restart more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32902D42586@orsmsx414.amr.corp.intel.com>
Date:	Fri, 11 May 2007 11:46:42 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<hadi@...erus.ca>
Cc:	"Herbert Xu" <herbert@...dor.apana.org.au>,
	"David Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: RE: [RFC] make qdisc_restart more readable

> For lockless drivers, I think it could be moved up; only 
> thing is nothing is stopping it from changing again at transmit time.
> For drivers that are not lockless, i am wondering if its even 
> useful to have that check given we have already grabbed the tx lock.

Good point.  I live in an LLTX world, so I don't think tx_lock mode very
often.

> 
> >   That
> > way you still hold dev->queue_lock in case the queue is 
> stopped, and 
> > haven't yet pulled an skb causing a requeue event.
> 
> It certainly sounds like a useful optimization. Defer that 
> thought - for now i just want to make sure its doing what the 
> previous code did.

Agreed.

> 
> I will repost the fixed patch later today after some testing; 
> if you have time i will appreciate some eyeballing. That 
> piece of code is hairy. Hopefully we can make it bald.

Clippers are standing by.  :)

-PJ
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html