netdev - Re: [patch 03/13] forcedeth: improve NAPI logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46441708.7020605@garzik.org>
Date:	Fri, 11 May 2007 03:11:04 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, mingo@...e.hu, aabdulla@...dia.com
Subject: Re: [patch 03/13] forcedeth: improve NAPI logic

akpm@...ux-foundation.org wrote:
> From: Ingo Molnar <mingo@...e.hu>
> 
> Another forcedeth.c thing: i noticed that its NAPI handler does not do
> tx-ring processing.  The patch below implements this - tested on DESC_VER_2
> hardware, with CONFIG_FORCEDETH_NAPI=y.
> 
> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> Cc: Ayaz Abdulla <aabdulla@...dia.com>
> ---
> Auke said:
> 
> the patch needs to be improved.
> 
> The following needs to be done when NAPI is enabled:
> - remove the tx handling within the ISRs
> - mask off the tx interrupts within the ISRs that handle tx processing
> - re-enable tx interrupts within the NAPI handler
> - add tx handling within the NAPI handler (this patch covers it)
> 
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/forcedeth.c |    8 ++++++++
>  1 file changed, 8 insertions(+)

This was NAK'd at least twice?

It's a half-finished project.  You need to do more, if moving TX from 
irq handler to NAPI.

I'm definitely not applying it, and as its incomplete, it definitely 
isn't suitable for upstream.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html