netdev - Re: [patch 4/5] s2io driver updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <jer6pkoo3e.fsf@sykes.suse.de>
Date:	Sun, 13 May 2007 15:22:13 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Ananda Raju <Ananda.Raju@...erion.com>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org,
	leonid.grossman@...erion.com, ravinandan.arakali@...erion.com,
	rapuru.sriram@...erion.com, alicia.pena@...erion.com
Subject: Re: [patch 4/5] s2io driver updates

Ananda Raju <Ananda.Raju@...erion.com> writes:

> @@ -2704,6 +2792,10 @@ static void tx_intr_handler(fifo_info_t 
>  		if (txdlp->Control_1 & TXD_T_CODE) {
>  			unsigned long long err;
>  			err = txdlp->Control_1 & TXD_T_CODE;
> +			if (err & 0x1) {

This is never true.

> @@ -5743,6 +6246,11 @@ static int rx_osm_handler(ring_info_t *r
>  	skb->dev = dev;
>  
>  	if (err) {
> +		/* Check for parity error */
> +		if (err & 0x1) {

Likewise.

(This is a very old patch, but the issue is still present.)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html