netdev - Re: [patch 04/13] ppp_generic: fix lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 May 2007 23:39:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...pl
Cc:	akpm@...ux-foundation.org, jeff@...zik.org, netdev@...r.kernel.org,
	jura@...ams.com, paulus@...ba.org
Subject: Re: [patch 04/13] ppp_generic: fix lockdep warning

From: Jarek Poplawski <jarkao2@...pl>
Date: Mon, 14 May 2007 08:07:00 +0200

> After sending this patch I was a little confused, when next
> lockdep warning report appeared, and I thought - since this is 
> not enough, this patch could be dumped. But now I changed my
> mind: there are really many possibilities of strange connections
> between locks taken from vlans, ppp (with pppoe), multicasts etc.
> - that every one possibility less is a gain here.
 ...
> Of course, later, if somebody will find better solution, they could
> be removed,

I already suggested a better fix, you ignored it.

For each unique netdev type, use a different locking class.

That will fix this forever, anything else is a situation specific
band-aid (but then again isn't that what every lockdep annotation is
:-).
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html