netdev - Re: Kconfig warnings on latest GIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070514013230.GJ3588@verge.net.au>
Date:	Mon, 14 May 2007 10:32:32 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Timur Tabi <timur@...escale.com>,
	Kim Phillips <kim.phillips@...escale.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Ismail Dönmez <ismail@...dus.org.tr>,
	Kumar Gala <galak@...nel.crashing.org>,
	Michael Schmitz <schmitz@...ian.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: Kconfig warnings on latest GIT

On Fri, May 11, 2007 at 01:45:37PM +0200, Johannes Berg wrote:
> On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote:
> 
> > Actually, it was with ARCH=ia64. I have a feeling that you can get
> > it to show up quite easily with anything other than ARCH=powerpc.
> 
> Ick, I didn't know that drivers/macintosh was now included for all
> arches! Hmm. That's a bit of a problem.
> 
> I could do
> 
> config PMAC_APM_EMU
>         tristate "APM emulation"
>         depends on SYS_SUPPORTS_APM_EMULATION
>         select APM_EMULATION
>         depends on ADB_PMU && PM
> 
> and then
> 
> config SYS_SUPPORTS_APM_EMULATION
> 	bool
> 	default y
> 	depends on PPC_PMAC
> 
> I'll have to run test that.

Hi Johannes,

I don't think that this is quite right, or at least it isn't quite the
same as before. I think that was is below will toggle
SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected,
which I think is what you want. Is it also neccessary to
add a dependancy on PPC_PMAC to PMAC_APM_EMU ?

config PMAC_APM_EMU
	tristate "APM emulation"
	select APM_EMULATION
	depends on ADB_PMU && PM

config SYS_SUPPORTS_APM_EMULATION
	bool
	default y if PMAC_APM_EMU

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html