netdev - [PATCH] [e1000] Lower the MSI unavailable message to INFO priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705152359.l4FNxPcS018779@tazenda.hos.anvin.org>
Date:	Tue, 15 May 2007 16:56:41 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	e1000-devel@...ts.sourceforge.net, john.ronciak@...el.com,
	jesse.brandeburg@...el.com, jeffrey.t.kirsher@...el.com,
	auke-jan.h.kok@...el.com
Cc:	netdev@...r.kernel.org, hpa@...or.com
Subject: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority

Currently, if MSI is enabled but unavailable the e1000 prints an error
message "Unable to allocate MSI interrupt Error" with ERR priority.
This is confusing to users since this is not a functionality error;
the driver will immediately afterwards try to acquire a conventional
PIC/APIC interrupt and will print another message if that fails.

Accordingly, lower the priority of this message to INFO priority, since
it does not reflect any sort of loss of functionality, but rather just a
limitation of the configuration of the runtime system.

Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
 drivers/net/e1000/e1000_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
 	if (adapter->hw.mac_type >= e1000_82571) {
 		adapter->have_msi = TRUE;
 		if ((err = pci_enable_msi(adapter->pdev))) {
-			DPRINTK(PROBE, ERR,
+			DPRINTK(PROBE, INFO,
 			 "Unable to allocate MSI interrupt Error: %d\n", err);
 			adapter->have_msi = FALSE;
 		}
-- 
1.5.1.4

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html