netdev - Re: [Cbe-oss-dev] [PATCH 10/10] spidernet: increase the NAPI weight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1179358492.4142.5.camel@concordia.ozlabs.ibm.com>
Date:	Thu, 17 May 2007 09:34:52 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Linas Vepstas <linas@...tin.ibm.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	cbe-oss-dev@...abs.org
Subject: Re: [Cbe-oss-dev] [PATCH 10/10] spidernet: increase the NAPI weight

On Wed, 2007-05-16 at 17:23 -0500, Linas Vepstas wrote:
> Another way of minimizing the likelyhood of RX ram from overflowing
> is to empty out the entire rx ring every chance we get. Change
> the crazy watchdog timeout from 50 seconds to 3 seconds, while
> we're here.
> 
> Signed-off-by: Linas Vepstas <linas@...tin.ibm.com>
> 
> ----
>  drivers/net/spider_net.h |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.22-rc1/drivers/net/spider_net.h
> ===================================================================
> --- linux-2.6.22-rc1.orig/drivers/net/spider_net.h	2007-05-16 12:00:35.000000000 -0500
> +++ linux-2.6.22-rc1/drivers/net/spider_net.h	2007-05-16 12:00:35.000000000 -0500
> @@ -56,8 +56,13 @@ extern char spider_net_driver_name[];
>  
>  #define SPIDER_NET_RX_CSUM_DEFAULT		1
>  
> -#define SPIDER_NET_WATCHDOG_TIMEOUT		50*HZ
> -#define SPIDER_NET_NAPI_WEIGHT			64
> +#define SPIDER_NET_WATCHDOG_TIMEOUT		3*HZ
> +
> +/* We really really want to empty the ring buffer every time,
> + * so as to avoid the RX ram full bug. So set te napi wieght

Speeeling ...................................... ^^ ^^^^ ^^^^^^

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)