netdev - Re: linux-2.6.22-rc1-g7b104bcb build #254 failed in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070517.000823.130237470.davem@davemloft.net>
Date:	Thu, 17 May 2007 00:08:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	toralf.foerster@....de
Cc:	netdev@...r.kernel.org
Subject: Re: linux-2.6.22-rc1-g7b104bcb build #254 failed in tcp_yeah.c

From: Toralf Förster <toralf.foerster@....de>
Date: Wed, 16 May 2007 22:18:44 +0200

> net/built-in.o: In function `tcp_yeah_init':
> tcp_yeah.c:(.text+0x526f8): undefined reference to `tcp_vegas_init'
> net/built-in.o: In function `tcp_yeah_pkts_acked':
> tcp_yeah.c:(.text+0x52756): undefined reference to `tcp_vegas_pkts_acked'
> net/built-in.o:(.data+0x96a0): undefined reference to `tcp_vegas_state'
> net/built-in.o:(.data+0x96a4): undefined reference to `tcp_vegas_cwnd_event'
> net/built-in.o:(.data+0x96b0): undefined reference to `tcp_vegas_get_info'
> make: *** [.tmp_vmlinux1] Error 1

Thanks for the report, I'll fix it like this:

commit 44c297027bdfa6b5530b011abbb60d9e728d46ed
Author: David S. Miller <davem@...set.davemloft.net>
Date:   Thu May 17 00:07:47 2007 -0700

    [TCP]: TCP_CONG_YEAH requires TCP_CONG_VEGAS
    
    These two congestion control modules share code.
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index c68196c..719c104 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -577,6 +577,7 @@ config TCP_CONG_VENO
 config TCP_CONG_YEAH
 	tristate "YeAH TCP"
 	depends on EXPERIMENTAL
+	select TCP_CONG_VEGAS
 	default n
 	---help---
 	YeAH-TCP is a sender-side high-speed enabled TCP congestion control
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html