lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 May 2007 02:49:40 +0900 (JST) From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> To: socketcan@...tkopp.net Cc: davem@...emloft.net, netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org Subject: Re: [FIX][PATCH] ipv6 addrconf.c : wrong handling of non-ipv6 hardware since 2.6.21 In article <464C886F.50703@...tkopp.net> (at Thu, 17 May 2007 18:53:03 +0200), Oliver Hartkopp <socketcan@...tkopp.net> says: > +static int ipv6_hwtype(struct net_device *dev) > +{ > + if ((dev->type == ARPHRD_ETHER) || > + (dev->type == ARPHRD_LOOPBACK) || > +#if defined(CONFIG_IPV6_SIT) || defined(CONFIG_IPV6_SIT_MODULE) > + (dev->type == ARPHRD_SIT) || > +#endif > + (dev->type == ARPHRD_TUNNEL6) || > + (dev->type == ARPHRD_FDDI) || > + (dev->type == ARPHRD_IEEE802_TR) || > + (dev->type == ARPHRD_ARCNET) || > + (dev->type == ARPHRD_INFINIBAND)) > + return 1; > + > + return 0; > +} > + Please remove #if, or please provide for other dependencies as well (e.g., CONFIG_IPV6_TUNNEL etc.) Otherwise, I would agree. -- YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@...ux-ipv6.org> GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists