lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 May 2007 17:15:24 -0400 From: Chuck Ebbert <cebbert@...hat.com> To: "Kok, Auke" <auke-jan.h.kok@...el.com> CC: Jeff Garzik <jeff@...zik.org>, "H. Peter Anvin" <hpa@...or.com>, e1000-devel@...ts.sourceforge.net, john.ronciak@...el.com, jesse.brandeburg@...el.com, jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org Subject: Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority Kok, Auke wrote: > Jeff Garzik wrote: >> H. Peter Anvin wrote: >>> diff --git a/drivers/net/e1000/e1000_main.c >>> b/drivers/net/e1000/e1000_main.c >>> index 637ae8f..089ae3f 100644 >>> --- a/drivers/net/e1000/e1000_main.c >>> +++ b/drivers/net/e1000/e1000_main.c >>> @@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter >>> *adapter) >>> if (adapter->hw.mac_type >= e1000_82571) { >>> adapter->have_msi = TRUE; >>> if ((err = pci_enable_msi(adapter->pdev))) { >>> - DPRINTK(PROBE, ERR, >>> + DPRINTK(PROBE, INFO, >>> "Unable to allocate MSI interrupt Error: %d\n", err); >>> adapter->have_msi = FALSE; >> >> >> Actually, it should not print any message at all. >> >> pci_enable_msi() failure is a normal event (as you point out). Even >> at KERN_INFO level, the message is still misleading. > > I've been reworking some of this code and there is even a > pci_disable_msi() missing in case pci_request_irq failed. I'll post a > patch to clean it up in a second. It seems ixgb needs this too (the message removal at least?) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists