netdev - Re: [PATCH] Fix incorrect prototype for ipxrtr_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070517.200357.112621854.davem@davemloft.net>
Date:	Thu, 17 May 2007 20:03:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dwmw2@...radead.org
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	acme@...stprotocols.net, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix incorrect prototype for ipxrtr_route_packet()

From: David Woodhouse <dwmw2@...radead.org>
Date: Fri, 18 May 2007 09:48:32 +0800

> On Thu, 2007-05-17 at 15:27 -0700, Andrew Morton wrote:
> > If only we could find some way in which all callers of a function as
> > well as its definition can see the same declaration? 
> 
> Well, building with --combine helps. :)
> 
> Admittedly it doesn't necessarily catch _all_ callers -- only those
> which we actually compile together. That does cover _most_ of the times
> we do crap like this without a prototype in a header file though, I
> suspect.
> 
> As Geert points out, sparse can warn about non-static functions which
> aren't prototyped; if we start getting anal about that, it might help.

I think it might be useful to be able to optionally to a --combine
build on the whole tree with like allyeconfig or something crazy like
that.  Just as a once-in-a-while thing to catch declaration mismatch
and other similar issues.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html