lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 May 2007 14:33:21 +0100 (BST) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: Andrew Morton <akpm@...ux-foundation.org>, Jeff Garzik <jgarzik@...ox.com> cc: netdev@...r.kernel.org Subject: [PATCH] declance: Remove a dangling spin_unlock_irq() thingy The spin_unlock_irq() invocation in lance_start_xmit() has no matching locking request. The call is already protected by netif_tx_lock, so remove the statement. Signed-off-by: Maciej W. Rozycki <macro@...ux-mips.org> --- Please apply. Maciej patch-mips-2.6.18-20060920-declance-lock-0 diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/declance.c linux-mips-2.6.18-20060920/drivers/net/declance.c --- linux-mips-2.6.18-20060920.macro/drivers/net/declance.c 2006-09-20 20:50:22.000000000 +0000 +++ linux-mips-2.6.18-20060920/drivers/net/declance.c 2007-05-19 21:14:36.000000000 +0000 @@ -915,8 +915,6 @@ static int lance_start_xmit(struct sk_bu /* Kick the lance: transmit now */ writereg(&ll->rdp, LE_C0_INEA | LE_C0_TDMD); - spin_unlock_irq(&lp->lock); - dev->trans_start = jiffies; dev_kfree_skb(skb); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists