netdev - Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 May 2007 18:36:57 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	netdev@...r.kernel.org, jmorris@...ei.org, Curtis@...enkey.net,
	davem@...emloft.net
Subject: Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr
 (fwd)

Herbert Xu wrote:
> Patrick McHardy <kaber@...sh.net> wrote:
> 
>>This leaves the question what to do in the path after ip_output,
>>when skb->dev points to the output device. We don't know the
>>input device anymore, so there doesn't seem to be a way to make
>>it do what the sysctl promises.
> 
> 
> Perhaps we could change things so that the setting of skb->dev is
> delayed until the packet has completely left the IP stack?  It'd
> require a massive audit though of the IP stack though.


The IP stack shouldn't be too hard, we currently set skb->dev in
ip_output, after that we only have the POST_ROUTING hook and ip_fragment
which care. It wouldn't help with ipip/ip_gre though, at that point
skb->dev must point to the tunnel device.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html