| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070521051311.GB7778@localhost.localdomain> Date: Mon, 21 May 2007 15:13:11 +1000 From: David Gibson <david@...son.dropbear.id.au> To: Stefan Roese <sr@...x.de> Cc: Eugene Surovegin <ebs@...home.net>, netdev@...r.kernel.org, linuxppc-dev@...abs.org Subject: Re: [PATCH] ibm_emac: Correctly detect old link speed On Wed, May 16, 2007 at 08:44:47PM +0200, Stefan Roese wrote: > On Wednesday 16 May 2007, Eugene Surovegin wrote: > > On Wed, May 16, 2007 at 01:00:08PM +0200, Stefan Roese wrote: > > > This patch fixes a bug where the link speed change was not > > > detected correctly. This occured on a 440SPe (EMAC4) system > > > where the old link speed was 100Mbps and the new link speed > > > is 1000Mbps. > > > > Good catch, Stefan. Unfortunately, I have to NACK your patch - you > > broke non EMAC4 builds. > > Yes, you're right of course. > > > Correct fix is just to remove EMAC_MR1_MF_1000GPCS from the first > > if condition. > > Yep. > > > I'll send correct fix shortly along with other queued patches. > > Thanks. I've merged essentially the same fix into the device tree aware "new_emac" driver. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists