netdev - Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070521212635.GA6234@gondor.apana.org.au>
Date:	Tue, 22 May 2007 07:26:35 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	cebbert@...hat.com, netdev@...r.kernel.org,
	jesse.brandeburg@...el.com
Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

On Mon, May 21, 2007 at 08:32:41AM -0700, Auke Kok wrote:
> Herbert Xy wrote:
> "netif_poll_enable can only be called if you've previously called
> netif_poll_disable.  Otherwise a poll might already be in action
> and you may get a crash like this."
> 
> Removing the call to netif_poll_enable in e1000_open should fix this issue,
> the only other call to netif_poll_enable is in e1000_up() which is only
> reached after a device reset or resume.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>

Looks good!

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html