lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 May 2007 23:32:44 +0200 From: Patrick McHardy <kaber@...sh.net> To: Herbert Xu <herbert@...dor.apana.org.au> CC: netdev@...r.kernel.org, jmorris@...ei.org, Curtis@...enkey.net, davem@...emloft.net Subject: Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd) Herbert Xu wrote: > On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote: > >>The IP stack shouldn't be too hard, we currently set skb->dev in >>ip_output, after that we only have the POST_ROUTING hook and ip_fragment >>which care. It wouldn't help with ipip/ip_gre though, at that point >>skb->dev must point to the tunnel device. > > > I think that should be OK though. Once you pass through ipip/ip_gre's > transmit function, you're conceptually a locally generated packet. Yes, but it may generate ICMP errors for the original packet before it has passed through it. The patch I sent earlier should also handle this case correctly. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists