| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070522230942.GT5921@austin.ibm.com> Date: Tue, 22 May 2007 18:09:42 -0500 From: linas@...tin.ibm.com (Linas Vepstas) To: Jeff Garzik <jgarzik@...ox.com>, Andrew Morton <akpm@...l.org> Cc: cbe-oss-dev@...abs.org, netdev@...r.kernel.org, linuxppc-dev@...abs.org, Florin Malita <fmalita@...il.com> Subject: [PATCH 1/10] spidernet: skb used after netif_receive_skb From: Florin Malita <fmalita@...il.com> The stats update code in spider_net_pass_skb_up() is touching the skb after it's been passed up to the stack. To avoid that, just update the stats first. Signed-off-by: Florin Malita <fmalita@...il.com> Signed-off-by: Linas Vepstas <linas@...tin.ibm.com> ---- drivers/net/spider_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c index 108adbf..1df2f0b 100644 Index: netdev-2.6/drivers/net/spider_net.c =================================================================== --- netdev-2.6.orig/drivers/net/spider_net.c 2007-05-21 17:40:49.000000000 -0500 +++ netdev-2.6/drivers/net/spider_net.c 2007-05-22 18:03:16.000000000 -0500 @@ -1014,12 +1014,12 @@ spider_net_pass_skb_up(struct spider_net */ } - /* pass skb up to stack */ - netif_receive_skb(skb); - /* update netdevice statistics */ card->netdev_stats.rx_packets++; card->netdev_stats.rx_bytes += skb->len; + + /* pass skb up to stack */ + netif_receive_skb(skb); } #ifdef DEBUG - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists