netdev - Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <94EFC504-8A34-455D-8DB7-89708C404709@kernel.crashing.org>
Date:	Wed, 23 May 2007 08:18:30 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev <netdev@...r.kernel.org>,
	Kim Phillips <kim.phillips@...escale.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type


On May 18, 2007, at 10:33 AM, Kim Phillips wrote:

> On Fri, 18 May 2007 09:07:42 -0500
> Kumar Gala <galak@...nel.crashing.org> wrote:
>
>>
>> On May 17, 2007, at 8:53 PM, Jeff Garzik wrote:
>>
>>> Kim Phillips wrote:
>>>> On Tue, 15 May 2007 17:45:19 -0400
>>>> Jeff Garzik <jeff@...zik.org> wrote:
>>>>> Kim Phillips wrote:
>>>>>> It was agreed that phy-connection-type was a better name for
>>>>>> the interface-type property, so this patch renames it.
>>>>>>
>>>>>> Also, the max-speed property name was determined too generic,
>>>>>> and is therefore eliminated in favour of phy-connection-type
>>>>>> derivation logic.
>>>>>>
>>>>>> includes corrections to copyright text.
>>>>>>
>>>>>> Signed-off-by: Kim Phillips <kim.phillips@...escale.com>
>>>>>> ---
>>>>>>  drivers/net/ucc_geth.c     |   40 +++++++++++++++
>>>>>> +------------------------
>>>>>>  drivers/net/ucc_geth_mii.c |    9 +++++----
>>>>>>  drivers/net/ucc_geth_mii.h |   10 +++++-----
>>>>>>  3 files changed, 26 insertions(+), 33 deletions(-)
>>>>> applied to #upstream
>>>>>
>>>> just to be clear; only the mpc8323e-mds board works on your
>>>> current #upstream-{fixes,linus}.
>>>> The mpc8323e-rdb and mpc8360e-mds require
>>>> phylib: add the ICPlus IP175C PHY driver
>>>> and phylib: enable RGMII-ID on the Marvell m88e1111 PHY
>>>> respectively in order to work.
>>>> I'm ok with the SGMII patches:
>>>> phylib: m88e1111: enable SGMII mode
>>>> gianfar: add support for SGMII
>>>> staying on #upstream, but 2 out of 3 boards are currently broken
>>>> for #upstream-{fixes,linus}.
>>>
>>> New hardware support is always "broken" until merged.  Nonetheless
>>> it is still new and outside the merge window.
>>
>> I think new is a little relative here.  The MPC8232-RDB & MPC8360E-
>> MDS boards worked with 2.6.21 and the UCC. They had support for the
>> PHYs that Kim's listed built directly into the ucc driver and not as
>> part of the phy lib.  Since we've moved to using the phy lib in
>> 2.6.22 we've broken these boards since their PHY drivers aren't
>> currently in linus's tree.
>>
>> Kim, correct me if I'm wrong.
>>
>
> thanks for clarifying that - it is indeed the case.

Jeff, any comments?

While I can see the view that the ICPlus & m88e1111 in RGMII may be  
"new" Kim did post these patches before the release of 2.6.21.

http://marc.info/?l=linux-netdev&m=117624199831578&w=2
http://marc.info/?l=linux-netdev&m=117624199831578&w=2

And I believe its our normal stance to not introduce regressions  
between kernel versions when possible.  It would be appreciated if  
you could push the two patches Kim has referenced to linus for 2.6.22  
otherwise we've created a regression in supporting the MPC8323 RDB &  
MPC8360 MDS boards.

thanks

- k

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html