Driver was reading value from one register, setting bit and then writing the wrong register. Signed-off-by: Stephen Hemminger --- a/drivers/net/sky2.c 2007-05-22 10:43:12.000000000 -0700 +++ b/drivers/net/sky2.c 2007-05-22 10:44:32.000000000 -0700 @@ -364,7 +364,7 @@ static void sky2_phy_init(struct sky2_hw /* for SFP-module set SIGDET polarity to low */ ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL); ctrl |= PHY_M_FIB_SIGD_POL; - gm_phy_write(hw, port, PHY_MARV_CTRL, ctrl); + gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl); } gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg); -- Stephen Hemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html