netdev - Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <46561667.1070105@pmc-sierra.com>
Date:	Thu, 24 May 2007 15:49:11 -0700
From:	Marc St-Jean <Marc_St-Jean@...-sierra.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Marc St-Jean <stjeanma@...-sierra.com>, akpm@...ux-foundation.org,
	linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver


Jeff Garzik wrote:
> Marc St-Jean wrote:
>  > I asked if the remaining section (above) was acceptable so we could 
> retain our
>  > buffer recycling which enhances throughput. I never received a rely 
> so it was
>  > left in my last patch.
>  >
>  > The above comment now answers my part of my initial question. Are you 
> aware of
>  > a better way to implement this or must we lose all our recycling 
> enhancements?
> 
> 
> You can poke around on netdev and ask about skb recycling in a new
> thread, and propose something.
> 
> I just know that having your own custom skb initialization is a
> non-starter.  Any updates the main skb init code receives will
> inevitably -not- be propagate to your code, rapidly leading to an
> unmaintainable disconnect.
> 
> skb recycling in general is an interesting area to explore, and others
> have poked around that area before.  I bet googling for skb recycling
> would turn up some useful thoughts and past efforts.
> 
>         Jeff
> 

I will resend the driver without the skb recycling shortly. We will need
to see if we can allocate resources to contribute to recycling at the
stack level later.

Thanks,
Marc
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html