lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 May 2007 19:04:08 +0200 From: Michael Buesch <mb@...sch.de> To: Andreas Schwab <schwab@...e.de> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Avoid switch on long long in s2io driver On Saturday 26 May 2007 10:58:15 Andreas Schwab wrote: > A switch on long long causes gcc to generate a reference to __ucmpdi2 on > ppc32. Avoid that by casting to int, since the value is only a small > integer anyway. > > Signed-off-by: Andreas Schwab <schwab@...e.de> > > --- > drivers/net/s2io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6.22-rc1/drivers/net/s2io.c > =================================================================== > --- linux-2.6.22-rc1.orig/drivers/net/s2io.c 2007-05-13 11:03:28.000000000 +0200 > +++ linux-2.6.22-rc1/drivers/net/s2io.c 2007-05-13 12:52:49.000000000 +0200 > @@ -2898,7 +2898,7 @@ static void tx_intr_handler(struct fifo_ > > /* update t_code statistics */ > err >>= 48; > - switch(err) { > + switch((int)err) { Hm, maybe add a comment, too? This cast looks redundant at the first look and someone who doesn't understand it might submit a patch to remove it again. > case 2: > nic->mac_control.stats_info->sw_stat. > tx_buf_abort_cnt++; > @@ -6825,7 +6825,7 @@ static int rx_osm_handler(struct ring_in > sp->mac_control.stats_info->sw_stat.parity_err_cnt++; > } > err >>= 48; > - switch(err) { > + switch((int)err) { > case 1: > sp->mac_control.stats_info->sw_stat. > rx_parity_err_cnt++; > > Andreas. > -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists