netdev - Re: [PATCH 0/9]: tcp-2.6 patchset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070527140430.GA30299@galon.ev-en.org>
Date:	Sun, 27 May 2007 17:04:30 +0300
From:	Baruch Even <baruch@...en.org>
To:	Ilpo J?rvinen <ilpo.jarvinen@...sinki.fi>
Cc:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/9]: tcp-2.6 patchset

* Ilpo J?rvinen <ilpo.jarvinen@...sinki.fi> [070527 14:16]:
> On Sun, 27 May 2007, David Miller wrote:
> 
> > From: "Ilpo_J?rvinen" <ilpo.jarvinen@...sinki.fi>
> > Date: Sun, 27 May 2007 10:58:27 +0300 (EEST)
> > 
> > > While you're in the right context (reviewing patch 8), you could also
> > > look if tcp_clean_rtx_queue does a right thing when passing a strange 
> > > pkts_acked to congestion control modules. I wonder if it really should 
> > > ignore GSO the way it does currently... I read some cc module code and 
> > > some was adding it to snd_cwnd_cnt, etc. which is a strong indication 
> > > that GSO should be considered... Also if the head is GSO skb that is not 
> > > completely acked, the loop breaks with pkts_acked being zero, I doubt
> > > that can be correct... 
> > 
> > [...snip...]
> > will likely take a look at these issues wrt. patch 8 tomorrow.
> 
> [...snip...]
> 
> Thus, my original question basically culminates in this: should cc
> modules be passed number of packets acked or number of skbs acked?
> ...The latter makes no sense to me unless the value is intented to
> be interpreted as number of timestamps acked or something along those 
> lines. ...I briefly tried looking up for documentation for cc module 
> interface but didn't find anything useful about this, and thus asked in 
> the first place...

At least the htcp module that I wrote assumes that the number is actual
number of tcp packets so GSO should be considered.

The consequences of this bug are not too large but it does make all
congestion control algorithms a lot less aggressive. On my machines GSO
is disabled by default (e1000 at 100mbps & Tigon3 @ 1Gbps).

Cheers,
Baruch
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html