netdev - b44-ssb: Remove redundant device reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200705271714.48272.mb@bu3sch.de>
Date:	Sun, 27 May 2007 17:14:48 +0200
From:	Michael Buesch <mb@...sch.de>
To:	John Linville <linville@...driver.com>
Cc:	Gary Zambrano <zambrano@...adcom.com>, netdev@...r.kernel.org
Subject: b44-ssb: Remove redundant device reset

This reset wasn't there in the old b44 driver
and I don't think it's needed for the 47xx either.
If it later turns out that this is really needed for
some weird 47xx, we can re-add it with a special case
branch for that particular device.

Signed-off-by: Michael Buesch <mb@...sch.de>

Index: bu3sch-wireless-dev/drivers/net/b44.c
===================================================================
--- bu3sch-wireless-dev.orig/drivers/net/b44.c	2007-05-27 16:59:22.000000000 +0200
+++ bu3sch-wireless-dev/drivers/net/b44.c	2007-05-27 17:03:32.000000000 +0200
@@ -2201,11 +2201,6 @@
 		printk("%2.2x%c", dev->dev_addr[i],
 		       i == 5 ? '\n' : ':');
 
-	/* Initialize phy */
-	spin_lock_irq(&bp->lock);
-	b44_chip_reset(bp);
-	spin_unlock_irq(&bp->lock);
-
 	return 0;
 
 err_out_free_dev:

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html