netdev - Re: [PATCH] merge dst_discard in & out into one, this decrements the vmlinux image by 21 bytes under i386 arch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0705281150010.11140@yvahk01.tjqt.qr>
Date:	Mon, 28 May 2007 11:50:32 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	rae l <crquan@...il.com>
cc:	"David S. Miller" <davem@...emloft.net>,
	Networking Team <netdev@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Adrian Bunk <trivial@...nel.org>
Subject: Re: [PATCH] merge dst_discard in & out into one, this decrements
 the vmlinux image by 21 bytes under i386 arch.


On May 28 2007 10:41, rae l wrote:
>
> diff --git a/net/core/dst.c b/net/core/dst.c
> index 764bccb..daa0439 100644
> --- a/net/core/dst.c
> +++ b/net/core/dst.c
> @@ -111,17 +111,14 @@ out:
>      spin_unlock(&dst_lock);
> }
>
> -static int dst_discard_in(struct sk_buff *skb)
> +static int dst_discard(struct sk_buff *skb)
> {
> kfree_skb(skb);
> return 0;
> }
>
> -static int dst_discard_out(struct sk_buff *skb)
> -{
> -       kfree_skb(skb);
> -       return 0;
> -}
> +#define dst_discard_in dst_discard
> +#define dst_discard_out        dst_discard

Uhm, just replace every invocation of dst_discard_in/_out() directly
by dst_discard ... don't add macros for that.


>
> void * dst_alloc(struct dst_ops * ops)
> {
>
>

	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html