netdev - Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2007 18:35:07 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	divy@...lsio.com
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	swise@...ngridcomputing.com
Subject: Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

divy@...lsio.com wrote:
> From: Divy Le Ray <divy@...lsio.com>
> 
> Fix netpoll handler to work with line interrupt, msi and msi-x.
> 
> Signed-off-by: Divy Le Ray <divy@...lsio.com>
> ---
> 
>  drivers/net/cxgb3/cxgb3_main.c |   12 +++++++++---
>  drivers/net/cxgb3/sge.c        |    1 -
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index 67b4b21..e0ef724 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -2076,10 +2076,16 @@ static void vlan_rx_kill_vid(struct net_
>  static void cxgb_netpoll(struct net_device *dev)
>  {
>  	struct adapter *adapter = dev->priv;
> -	struct sge_qset *qs = dev2qset(dev);
> +	struct port_info *pi = netdev_priv(dev);
> +	int qidx;
>  
> -	t3_intr_handler(adapter, qs->rspq.polling) (adapter->pdev->irq,
> -						    adapter);
> +	for (qidx = pi->first_qset; qidx < pi->first_qset + pi->nqsets; qidx++) {
> +		struct sge_qset *qs = &adapter->sge.qs[qidx];
> +		
> +		t3_intr_handler(adapter, qs->rspq.polling) (0, 
> +					(adapter->flags & USING_MSIX) ?
> +					(void *)qs : (void *)adapter);

Remove needless casts to void*


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html