netdev - Re: Generic netlink interface help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2007 09:41:20 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Samuel Ortiz <samuel@...tiz.org>
Cc:	netdev@...r.kernel.org
Subject: Re: Generic netlink interface help

On Mon, May 28, 2007 at 04:42:47AM +0300, Samuel Ortiz wrote:
> > 
> > Is that right?
> At first glance, this could work yes.

Great! Now I have only to write the userland tool. :)

> However, it seems you're trying to encapsulate your pps_netlink_msg into
> a generic netlink message which itself is already encapsulated into a
> netlink message, and then multiplex all your PPS commands on
> ppl_genl_data_ready(). IMHO, you should have your different PPS commands
> declared as a genl_ops array, and then have a specific doit routine per PPS
> command. This would make your code cleaner and more secure (see the
> "Operation Granularity" section at
> http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO).

I see. I already supposed that but currently I'm trying to do minimal
changes to my code in order to verify that everythink works well
again, then I'll do the complete work.

Thanks a lot,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html