lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 May 2007 17:22:30 -0400 From: Doug Chapman <doug.chapman@...com> To: doug.chapman@...com, herbert@...dor.apana.org.au, auke-jan.h.kok@...el.com, netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net Subject: REGRESSION: panic on e1000 driver All, I reported this a few weeks ago and it was fixed but it appears the offending code was again re-submitted. This causes a panic on HP Integrity servers and from what I hear many other platforms using e1000 as well. My original report was via kernel.org BZ: http://bugzilla.kernel.org/show_bug.cgi?id=8455 I am seeing the same panic with a kernel built from today's git pull. It was fixed by this commit: 3e1657c8ef53e1cd541cc1e420f3230dc075949b but once again broken just yesterday by the following commit. I have backed just this commit out and verified I no longer panic. commit 47313054352b879a2bc65379d55b05f48a0af7ec Author: Herbert Xu <herbert@...dor.apana.org.au> Date: Tue May 29 15:07:31 2007 -0700 e1000: restore netif_poll_enable call but make sure IRQs are off This restores the previously removed netif_poll_enable call in e1000_open. It's needed on all but the first call to e1000_open for a NIC as e1000_close always calls netif_poll_disable. netif_poll_enable can only be called safely if no polls have been scheduled. This should be the case as long as we don't enter our IRQ handler. In order to guarantee this we explicitly disable IRQs as early as possible when we're probing the NIC. Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> Cc: "Kok, Auke" <auke-jan.h.kok@...el.com> Cc: Jeff Garzik <jeff@...zik.org> Cc: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Jeff Garzik <jeff@...zik.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists