| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 May 2007 03:59:02 -0400 From: Bill Nottingham <notting@...hat.com> To: netdev@...r.kernel.org Cc: jgarzik@...ox.com, linux-kernel@...r.kernel.org Subject: [PATCH] drivers/net: fix comparisons of unsigned < 0 Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <notting@...hat.com> --- mlx4/qp.c | 3 +-- netxen/netxen_nic_niu.c | 6 +++--- tulip/de2104x.c | 1 - 3 files changed, 4 insertions(+), 6 deletions(-) diff -ru linux-2.6.21-old/drivers/net/mlx4/qp.c linux-2.6.21/drivers/net/mlx4/qp.c --- linux-2.6.21-old/drivers/net/mlx4/qp.c 2007-05-30 02:52:53.000000000 -0400 +++ linux-2.6.21/drivers/net/mlx4/qp.c 2007-05-30 02:18:33.000000000 -0400 @@ -113,8 +113,7 @@ struct mlx4_cmd_mailbox *mailbox; int ret = 0; - if (cur_state < 0 || cur_state >= MLX4_QP_NUM_STATE || - new_state < 0 || cur_state >= MLX4_QP_NUM_STATE || + if (cur_state >= MLX4_QP_NUM_STATE || cur_state >= MLX4_QP_NUM_STATE || !op[cur_state][new_state]) return -EINVAL; diff -ru linux-2.6.21-old/drivers/net/netxen/netxen_nic_niu.c linux-2.6.21/drivers/net/netxen/netxen_nic_niu.c --- linux-2.6.21-old/drivers/net/netxen/netxen_nic_niu.c 2007-05-30 02:52:53.000000000 -0400 +++ linux-2.6.21/drivers/net/netxen/netxen_nic_niu.c 2007-05-30 02:20:02.000000000 -0400 @@ -728,7 +728,7 @@ __u32 mac_cfg0; u32 port = physical_port[adapter->portnum]; - if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) + if (port > NETXEN_NIU_MAX_GBE_PORTS) return -EINVAL; mac_cfg0 = 0; netxen_gb_soft_reset(mac_cfg0); @@ -761,7 +761,7 @@ __u32 reg; u32 port = physical_port[adapter->portnum]; - if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) + if (port > NETXEN_NIU_MAX_GBE_PORTS) return -EINVAL; /* save previous contents */ @@ -898,7 +898,7 @@ __u32 reg; u32 port = physical_port[adapter->portnum]; - if ((port < 0) || (port > NETXEN_NIU_MAX_XG_PORTS)) + if (port > NETXEN_NIU_MAX_XG_PORTS) return -EINVAL; if (netxen_nic_hw_read_wx(adapter, diff -ru linux-2.6.21-old/drivers/net/tulip/de2104x.c linux-2.6.21/drivers/net/tulip/de2104x.c --- linux-2.6.21-old/drivers/net/tulip/de2104x.c 2007-05-30 02:52:53.000000000 -0400 +++ linux-2.6.21/drivers/net/tulip/de2104x.c 2007-05-30 02:20:44.000000000 -0400 @@ -785,7 +785,6 @@ de->tx_head = NEXT_TX(entry); - BUG_ON(TX_BUFFS_AVAIL(de) < 0); if (TX_BUFFS_AVAIL(de) == 0) netif_stop_queue(dev); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists