lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 May 2007 20:42:24 -0400 From: Jeff Garzik <jeff@...zik.org> To: Jeremy Fitzhardinge <jeremy@...p.org> CC: divy@...lsio.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, swise@...ngridcomputing.com Subject: Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder Jeremy Fitzhardinge wrote: > Jeff Garzik wrote: >>> + t3_intr_handler(adapter, qs->rspq.polling) (0, >>> + (adapter->flags & USING_MSIX) ? >>> + (void *)qs : (void *)adapter); >> Remove needless casts to void* > The two branches of ?: need to have the same type; without the casts > they'd be "struct sge_qset" and "struct adapter". Seems a bit cruddy to > have two types passed to one function depending on the MSI state, but > maybe that's OK. Look at the function argument... Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists