netdev - Re: [PATCH 4/7] sky2: PHY page register fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 May 2007 09:59:32 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/7] sky2: PHY page register fixes

Stephen Hemminger wrote:
> Several of the PHY registers are multiplexed; access to
> register must be proceeded by setting page register.
> 
> The driver setup is safer if this is done before the access
> rather than depending on the last value.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>

NAK for 2.622 - this appears to be a highly speculative cleanup-style 
change that is not an appropriate submission so late in the Release 
Candidate cycle.

I would have expected this sort of change to have been brewing for a 
little while in -mm, via netdev#upstream perhaps.  As it is, this change 
has been zero testing exposure, which is not something we want in a -rc2 
or -rc3.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html