netdev - Re: bond_compute_features() does not handle devices with different CSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 May 2007 09:58:38 -0700
From:	"Laurent Chavey" <chavey@...gle.com>
To:	"Stephen Hemminger" <shemminger@...ux-foundation.org>
Cc:	netdev@...r.kernel.org
Subject: Re: bond_compute_features() does not handle devices with different CSUM

should we then move/integrate that code as part of the bonding driver ?


On 5/30/07, Stephen Hemminger <shemminger@...ux-foundation.org> wrote:
> On Tue, 29 May 2007 17:41:45 -0700
> "Laurent Chavey" <chavey@...gle.com> wrote:
>
> > kernel version <= 2.6.20.1
> > file drivers/net/bonding/bonding_main.c
> > function bond_compute_features()
> >
> > -----------
> >   Given a system with two different NIC. One driver sets
> >         dev->features |=  NETIF_F_HW_CSUM
> >   the other driver sets
> >         dev->features |=  NETIF_F_IP_CSUM
> >
> >   when enslaving the 2 device above, bond_compute_features()
> >   does not set the intersection of the 2 CSUM
> >   features (should be NETIF_F_IP_CSUM)
> > -----------
> >
> >    should the bond features in the case above include NETIF_F_IP_CSUM
> > -
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> The bridge code already has a more complete/complex recompute
> routine to handle this.
>
> --
> Stephen Hemminger <shemminger@...ux-foundation.org>
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html